Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Enhance Advice records with source location #1444

Closed
1 task done
Tracked by #1085
ericvergnaud opened this issue Apr 18, 2024 · 0 comments · Fixed by #1529
Closed
1 task done
Tracked by #1085

[FEATURE]: Enhance Advice records with source location #1444

ericvergnaud opened this issue Apr 18, 2024 · 0 comments · Fixed by #1529
Assignees
@ericvergnaud
Labels
migrate/code Abstract Syntax Trees and other dark magic migrate/python Pull requests that update Python code tech debt chores and design flaws

Comments

@ericvergnaud
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

Advice records do not currently hold information about the location of the source code from which they are generated

Proposed Solution

Add the missing information

Additional Context

No response
@ericvergnaud ericvergnaud added enhancement New feature or request needs-triage labels Apr 18, 2024
@ericvergnaud ericvergnaud mentioned this issue Apr 18, 2024
Closed
11 tasks
@nfx nfx added tech debt chores and design flaws migrate/code Abstract Syntax Trees and other dark magic migrate/python Pull requests that update Python code and removed enhancement New feature or request needs-triage labels Apr 22, 2024
@nfx nfx mentioned this issue Apr 22, 2024
Open
26 tasks
@ericvergnaud ericvergnaud mentioned this issue Apr 24, 2024
Merged
11 tasks
@nfx nfx closed this as completed in #1529 Apr 24, 2024
nfx pushed a commit that referenced this issue Apr 24, 2024
@ericvergnaud
When building dependency graph, raise problems with problematic depen…
42b3c7c 
…dencies (#1529)

## Changes
Create a DependencyProblem class, than can later be converted to Advice
Whenever a problem is encountered, 

### Linked issues
#1202
Resolves #1444
Resolves #1431
Resolves #1439

### Functionality 

- [ ] added relevant user documentation
- [ ] added new CLI command
- [ ] modified existing command: `databricks labs ucx ...`
- [ ] added a new workflow
- [ ] modified existing workflow: `...`
- [ ] added a new table
- [ ] modified existing table: `...`

### Tests

- [ ] manually tested
- [x] added unit tests
- [ ] added integration tests
- [ ] verified on staging environment (screenshot attached)


Supersedes PRs #1447 and #1448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericvergnaud ericvergnaud

Labels
migrate/code Abstract Syntax Trees and other dark magic migrate/python Pull requests that update Python code tech debt chores and design flaws
Projects
UCX (roadmap)
Archived in project
Milestone
No milestone
2 participants
@nfx @ericvergnaud