Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: SPN crawling logic does not work correctly for cluster #896

Closed
1 task done
nkvuong opened this issue Feb 5, 2024 · 0 comments · Fixed by #942
Closed
1 task done

[BUG]: SPN crawling logic does not work correctly for cluster #896

nkvuong opened this issue Feb 5, 2024 · 0 comments · Fixed by #942
Assignees
@nkvuong
Labels
bug Something isn't working cloud/azure issues related to Azure

Comments

@nkvuong
Copy link
Contributor

nkvuong commented Feb 5, 2024 •
edited by nfx
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

test_spn_crawler_with_available_secrets detects secret id on an existing legacy spn cluster, but could not detect the spn secret stored in secret scope or the storage account

Related issues:

Expected Behavior

Both secret scope & storage account should be populated

Steps To Reproduce

No response

Cloud

Azure

Operating System

macOS

Version

latest via Databricks CLI

Relevant log output

No response
@nkvuong nkvuong added bug Something isn't working needs-triage labels Feb 5, 2024
@nkvuong nkvuong self-assigned this Feb 5, 2024
@nfx nfx added cloud/azure issues related to Azure credentials and removed needs-triage labels Feb 5, 2024
@nfx nfx mentioned this issue Feb 7, 2024
Closed
@nkvuong nkvuong mentioned this issue Feb 13, 2024
Merged
4 tasks
@nfx nfx closed this as completed in #942 Feb 15, 2024
nfx pushed a commit that referenced this issue Feb 15, 2024
@nkvuong
Refactor Azure service principal crawler and fix bug where `tenant_id…
2a6b090 
…` inside secret scope is not detected (#942)

## Changes
- Fix tenant_id detection logic In the case where spn endpoint
configuration is also inside a secret scope.
- Refactoring spn crawler logic to make it more readable

### Linked issues
Closes #896

### Tests
<!-- How is this tested? Please see the checklist below and also
describe any other relevant tests -->

- [x] manually tested
- [ ] added unit tests
- [ ] added integration tests
- [ ] verified on staging environment (screenshot attached)
dmoore247 pushed a commit that referenced this issue Mar 23, 2024
@nkvuong @dmoore247
Refactor Azure service principal crawler and fix bug where `tenant_id…
ce932fc 
…` inside secret scope is not detected (#942)

## Changes
- Fix tenant_id detection logic In the case where spn endpoint
configuration is also inside a secret scope.
- Refactoring spn crawler logic to make it more readable

### Linked issues
Closes #896

### Tests
<!-- How is this tested? Please see the checklist below and also
describe any other relevant tests -->

- [x] manually tested
- [ ] added unit tests
- [ ] added integration tests
- [ ] verified on staging environment (screenshot attached)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkvuong nkvuong

Labels
bug Something isn't working cloud/azure issues related to Azure
Projects
UCX (weekly)
Archived in project
Milestone
No milestone
2 participants
@nfx @nkvuong