Fix integration test with new DeployedWorkflows #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ 138/138 passed, 7 flaky, 20 skipped, 3h12m31s total Flaky tests:
Running from acceptance #1992 |
This was referenced Apr 4, 2024
ericvergnaud
added a commit
to ericvergnaud/ucx
that referenced
this pull request
Apr 5, 2024
* main: remove `isort` (databrickslabs#1280) Addressed Issue with Disabled Feature in certain regions (databrickslabs#1275) Improve documentation (databrickslabs#1162) Add roadmap workflows and tasks to Table Migration Workflow document (databrickslabs#1274) Fix integration test with new DeployedWorkflows (databrickslabs#1250) Document troubleshooting guide (databrickslabs#1226) Split `DeployedWorkflows` out of `WorkflowsDeployment` (databrickslabs#1248) Inject `_TASKS` via constructor to `WorkflowsDeployment` instead of a global variable (databrickslabs#1247) Decouple `InstallState` from `WorkspaceDeployment` constructor Add document for table migration workflow (databrickslabs#1229) Decouple `InstallState` from `WorkflowsDeployment` constructor (databrickslabs#1246)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
test_installation.pyintegration tests with newDeployedWorkflowstables,grants,groupsinventory database table to avoid crawling them from scratch which slows down the test. This fixes Test failure:test_table_migration_job_cluster_override#1245, Test failure:test_table_migration_job#1243test_migrate_managed_tables_with_principal_acl_azure#1242 , because the issue here caused infinite retry until timeout, as source table hasWhat.EXTERNAL_SYNCbut the test is trying to upgradeWhat. DBFS_ROOT_DELTALinked issues
Resolves #1242
Resolves #1245
Resolves #1243