Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Build site-packages dependencies #1420

Conversation

ericvergnaud
Copy link
Contributor

Changes

When locating import dependencies, if a package is not a known one, add package files as dependencies

Linked issues

#1202

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs ucx ...
  • added a new workflow
  • modified existing workflow: ...
  • added a new table
  • modified existing table: ...

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • verified on staging environment (screenshot attached)

@ericvergnaud ericvergnaud requested review from a team and dmoore247 April 16, 2024 14:26
@ericvergnaud
Copy link
Contributor Author

@nfx this is ready for review but I want to do #1421 as part of this PR. (this is becoming spaghetti, I want to prevent it from getting worse)

@ericvergnaud
Copy link
Contributor Author

@nfx I also want to do #1427 . This might become too big a PR, let me know your preference.

@ericvergnaud
Copy link
Contributor Author

Closed in favor of #1440
I'll do #1421 in a separate PR

@ericvergnaud ericvergnaud deleted the build-site-packages-dependencies branch April 23, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant