Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used MockInstallation consistently instead of create_autospec(Installation) #1649

Merged
merged 3 commits into from
May 7, 2024

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented May 7, 2024

Changes

Tests

  • manually tested
  • verified on staging environment (screenshot attached)

@nkvuong nkvuong requested review from a team and aminmovahed-db May 7, 2024 11:10
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (1350995) to head (55dc8cd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1649   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files          86       86           
  Lines       10584    10584           
  Branches     1865     1865           
=======================================
  Hits         9545     9545           
  Misses        679      679           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 7, 2024

✅ 160/160 passed, 25 skipped, 2h29m54s total

Running from acceptance #3039

Copy link
Contributor

@JCZuurmond JCZuurmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@nfx nfx disabled auto-merge May 7, 2024 15:46
@nfx nfx merged commit de47931 into main May 7, 2024
7 checks passed
@nfx nfx deleted the fix/mock_installation branch May 7, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants