Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always install the latest pip version in ./install.sh #201

Merged
merged 1 commit into from
Sep 15, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@ $py -m venv "$tmp_dir"
# Use the Python from Virtualenv
py="$tmp_dir/bin/python"

echo "[+] making sure we have the latest pip version"
# Always upgrade pip, so that the hatchling build backend works. Hinted by errors like
# > File "setup.py" or "setup.cfg" not found. Directory cannot be installed in editable mode
#
# See https://github.com/databrickslabs/ucx/issues/198
$py -m pip install --quiet --upgrade pip

echo "[+] installing dependencies within ephemeral Virtualenv: $tmp_dir"
# Install all project dependencies, so that installer can proceed
$py -m pip install --quiet -e .
Expand Down