Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors better in tables.scala (#243) #251

Merged
merged 1 commit into from
Sep 21, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/databricks/labs/ucx/hive_metastore/tables.scala
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import org.apache.spark.sql.catalyst.analysis.NoSuchDatabaseException
import org.apache.spark.sql.catalyst.catalog.{CatalogTable, CatalogTableType}
import org.apache.spark.sql.DataFrame

Expand All @@ -10,7 +11,13 @@ def metadataForAllTables(databases: Seq[String]): DataFrame = {

val externalCatalog = spark.sharedState.externalCatalog
databases.par.flatMap(databaseName => {
val tables = externalCatalog.listTables(databaseName)
val tables = try {
externalCatalog.listTables(databaseName)
} catch {
case err: NoSuchDatabaseException =>
println(s"[ERROR][${databaseName}] ignoring database because of ${err}")
null
}
if (tables == null) {
println(s"[WARN][${databaseName}] listTables returned null")
Seq()
Expand Down
Loading