Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL External HMS Support for HMS Federation #3385

Merged
merged 10 commits into from
Dec 20, 2024
Merged

MySQL External HMS Support for HMS Federation #3385

merged 10 commits into from
Dec 20, 2024
+284 −42

Conversation

FastLee
Copy link
Contributor

@FastLee FastLee commented Nov 26, 2024 •
edited
Loading

Added support for SQL Based HMS (MySQL) when creating an HMS Federated Catalog

@FastLee FastLee force-pushed the feat/hms_fed_ext_hms_3011 branch from debe61a to 0f5875b Compare December 13, 2024 22:59
@FastLee FastLee force-pushed the feat/hms_fed_ext_hms_3011 branch from 0f5875b to b040c92 Compare December 18, 2024 14:28
@FastLee FastLee marked this pull request as ready for review December 18, 2024 14:29
@FastLee FastLee requested a review from a team as a code owner December 18, 2024 14:29
@FastLee FastLee requested a review from JCZuurmond December 18, 2024 14:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

✅ 59/59 passed, 24 skipped, 3h53m5s total

Running from acceptance #7803

JCZuurmond
JCZuurmond requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@JCZuurmond JCZuurmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add more context to the first PR comment and make the title less cryptic. These are used in the change log when we release.

src/databricks/labs/ucx/hive_metastore/federation.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/federation.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/federation.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/federation.py Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/federation.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/federation.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/federation.py Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/federation.py Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/federation.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/federation.py Outdated Show resolved Hide resolved
@FastLee FastLee requested a review from JCZuurmond December 19, 2024 15:40
JCZuurmond
JCZuurmond approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@JCZuurmond JCZuurmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/databricks/labs/ucx/hive_metastore/federation.py Show resolved Hide resolved
@FastLee FastLee enabled auto-merge December 20, 2024 15:02
@FastLee FastLee added this pull request to the merge queue Dec 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2024
@FastLee FastLee changed the title Feat/hms fed ext hms 3011 MySQL External HMS Support for HMS Federation Dec 20, 2024
@FastLee FastLee added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit e768af2 Dec 20, 2024
7 checks passed
@FastLee FastLee deleted the feat/hms_fed_ext_hms_3011 branch December 20, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCZuurmond JCZuurmond JCZuurmond approved these changes

Assignees

@FastLee FastLee

Labels
None yet
Projects
UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FastLee @JCZuurmond