Check if permissions are up to date #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How can this happen in the first place? Could you add some info around this use-case? Or edge case? |
nfx
requested changes
Oct 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 79.55% 79.72% +0.17%
==========================================
Files 31 31
Lines 3116 3152 +36
Branches 599 611 +12
==========================================
+ Hits 2479 2513 +34
Misses 494 494
- Partials 143 145 +2
|
nfx
reviewed
Oct 10, 2023
nfx
requested changes
Oct 10, 2023
nfx
reviewed
Oct 10, 2023
william-conti
force-pushed
the
fix_multithreaded_group_migration
branch
from
8fbd2fd
to
caddf4c
Compare
william-conti
changed the title
william-conti
force-pushed
the
fix_multithreaded_group_migration
branch
2 times, most recently
from
d22adfe
to
05206af
Compare
william-conti
force-pushed
the
fix_multithreaded_group_migration
branch
from
b005248
to
6f08b60
Compare
william-conti
force-pushed
the
fix_multithreaded_group_migration
branch
from
8706168
to
47a8bf1
Compare
nfx
approved these changes
Oct 12, 2023
Merged
FastLee
pushed a commit
that referenced
this pull request
Oct 25, 2023
Attempt to fix #36 Goal of this PR is to add a validation in each class that implements the Crawler and Applier class. This validation step will verify that a permissions that has been applied to an object is correct, if it's not the case, it attemps to re-apply this permission multiple times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #36
Goal of this PR is to add a validation in each class that implements the Crawler and Applier class.
This validation step will verify that a permissions that has been applied to an object is correct, if it's not the case, it attemps to re-apply this permission multiple times