Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Failure Summary in the assessment dashboard #455

Merged
merged 34 commits into from
Oct 16, 2023
Merged

Conversation

dipankarkush-db
Copy link
Contributor

Fixes #309

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #455 (7272d5f) into main (bc4c1af) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

❗ Current head 7272d5f differs from pull request most recent head e138ff1. Consider uploading reports for the commit e138ff1 to get more accurate results

@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   80.18%   80.13%   -0.06%     
==========================================
  Files          31       31              
  Lines        3175     3181       +6     
  Branches      614      614              
==========================================
+ Hits         2546     2549       +3     
- Misses        482      485       +3     
  Partials      147      147              
Files Coverage Δ
src/databricks/labs/ucx/runtime.py 46.34% <50.00%> (+0.18%) ⬆️

@dipankarkush-db dipankarkush-db added the pr/do-not-merge this pull request is not ready to merge label Oct 13, 2023
@nfx
Copy link
Collaborator

nfx commented Oct 13, 2023

@dipankarkush-db don't forget to add screenshot

Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to add a screenshot

@dipankarkush-db
Copy link
Contributor Author

dipankarkush-db commented Oct 13, 2023

@dipankarkush-db don't forget to add screenshot

image

@dipankarkush-db dipankarkush-db removed the pr/do-not-merge this pull request is not ready to merge label Oct 13, 2023
@dipankarkush-db dipankarkush-db marked this pull request as ready for review October 13, 2023 21:05
@dipankarkush-db dipankarkush-db requested a review from a team October 13, 2023 21:05
src/databricks/labs/ucx/runtime.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/runtime.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/runtime.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/runtime.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/runtime.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/runtime.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/runtime.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/runtime.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/runtime.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/runtime.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/runtime.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/runtime.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/runtime.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/runtime.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/runtime.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and do the same changes in the other places

src/databricks/labs/ucx/runtime.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/runtime.py Outdated Show resolved Hide resolved
@nfx nfx changed the title Added Failure Summary in the dashboard. Added Failure Summary in the assessment dashboard Oct 16, 2023
@nfx nfx merged commit 6663996 into main Oct 16, 2023
3 checks passed
@nfx nfx deleted the feature/failure_summary branch October 16, 2023 15:38
@nfx nfx mentioned this pull request Oct 18, 2023
FastLee pushed a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single view and widget to show all unique assessment failures in the workspace
2 participants