Added make install-dev and a stronger make clean for easier dev on-boarding and release upgrades.
#458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… easier on-boarding experience
Codecov Report
@@ Coverage Diff @@
## main #458 +/- ##
=======================================
Coverage 80.13% 80.13%
=======================================
Files 31 31
Lines 3151 3151
Branches 611 611
=======================================
Hits 2525 2525
Misses 479 479
Partials 147 147 |
dmoore247
changed the title
make install-dev and a stronger make clean for easier dev on-boarding and release upgrades.
nfx
requested changes
Oct 14, 2023
Makefile
Outdated
| clean: | ||
| rm -fr htmlcov .mypy_cache .pytest_cache .ruff_cache .coverage coverage.xml | ||
| hatch env remove unit | ||
|
|
||
| install-dev: |
There was a problem hiding this comment.
Suggested change
| install-dev: | |
| dev: |
We use this for python sdk
| @@ -11,4 +19,5 @@ test: | |||
| hatch run unit:test | |||
|
|
|||
| test-cov: | |||
nfx
requested changes
Oct 14, 2023
| install-dev: | ||
| pip install hatch | ||
| hatch env create | ||
| hatch run pip install -e '.[test]' |
There was a problem hiding this comment.
Can you output the path to python interpreter here?
There was a problem hiding this comment.
as in which python ?
There was a problem hiding this comment.
I think Serge means this:
hatch run python -c "import sys; print(sys.executable)"
nfx
approved these changes
Oct 14, 2023
Merged
FastLee
pushed a commit
that referenced
this pull request
Oct 25, 2023
…n-boarding and release upgrades. (#458)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… easier on-boarding experience
The problem was
make testwas reporting incompatible versions. Thehatchenvironment needed cleaning up. Also addedmake install-devas a convention to install the developer environment (hatch).