Fix installation issue when upgrading from an older version of the tool and improve logs #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwojtyczka
temporarily deployed
to
account-admin
GitHub Actions
Inactive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
=======================================
Coverage 79.43% 79.44%
=======================================
Files 42 42
Lines 4411 4412 +1
Branches 819 819
=======================================
+ Hits 3504 3505 +1
Misses 693 693
Partials 214 214 ☔ View full report in Codecov by Sentry. |
mwojtyczka
temporarily deployed
to
account-admin
GitHub Actions
Inactive
nfx
approved these changes
Dec 27, 2023
| @@ -192,7 +192,7 @@ def _remote_folder_object(self) -> workspace.ObjectInfo: | |||
| def _installed_query_state(self): | |||
| if not self._state.dashboards: | |||
| for k, v in self._state_pre_v06().items(): | |||
| prefix, suffix = k.split(":", 2) | |||
| prefix, suffix = [*k.split(":"), None][:2] | |||
There was a problem hiding this comment.
please add tests, as suggested by codecov bot.
nfx
pushed a commit
that referenced
this pull request
Dec 28, 2023
* Corrected unit test setup as per PR [740](#740) * Fixed corrupted state warning
Merged
nfx
added a commit
that referenced
this pull request
Dec 28, 2023
* Added `databricks labs ucx repair-run --step ...` CLI command for repair run of any failed workflows, like `assessment`, `migrate-groups` etc. ([#724](#724)). * Added `databricks labs ucx revert-migrated-table` command ([#729](#729)). * Allow specifying a group list when group match options are used ([#725](#725)). * Fixed installation issue when upgrading from an older version of the tool and improve logs ([#740](#740)). * Renamed summary panel from Failure Summary to Assessment Summary ([#733](#733)). * Retry internal error when getting permissions and update legacy table ACL documentation ([#728](#728)). * Speedup installer execution ([#727](#727)).
nfx
added a commit
that referenced
this pull request
Dec 28, 2023
* Added `databricks labs ucx repair-run --step ...` CLI command for repair run of any failed workflows, like `assessment`, `migrate-groups` etc. ([#724](#724)). * Added `databricks labs ucx revert-migrated-table` command ([#729](#729)). * Allow specifying a group list when group match options are used ([#725](#725)). * Fixed installation issue when upgrading from an older version of the tool and improve logs ([#740](#740)). * Renamed summary panel from Failure Summary to Assessment Summary ([#733](#733)). * Retry internal error when getting permissions and update legacy table ACL documentation ([#728](#728)). * Speedup installer execution ([#727](#727)).
HariGS-DB
pushed a commit
that referenced
this pull request
Jan 2, 2024
* Corrected unit test setup as per PR [740](#740) * Fixed corrupted state warning
HariGS-DB
pushed a commit
that referenced
this pull request
Jan 2, 2024
* Added `databricks labs ucx repair-run --step ...` CLI command for repair run of any failed workflows, like `assessment`, `migrate-groups` etc. ([#724](#724)). * Added `databricks labs ucx revert-migrated-table` command ([#729](#729)). * Allow specifying a group list when group match options are used ([#725](#725)). * Fixed installation issue when upgrading from an older version of the tool and improve logs ([#740](#740)). * Renamed summary panel from Failure Summary to Assessment Summary ([#733](#733)). * Retry internal error when getting permissions and update legacy table ACL documentation ([#728](#728)). * Speedup installer execution ([#727](#727)).
FastLee
pushed a commit
that referenced
this pull request
Jan 19, 2024
* Corrected unit test setup as per PR [740](#740) * Fixed corrupted state warning
FastLee
pushed a commit
that referenced
this pull request
Jan 19, 2024
* Added `databricks labs ucx repair-run --step ...` CLI command for repair run of any failed workflows, like `assessment`, `migrate-groups` etc. ([#724](#724)). * Added `databricks labs ucx revert-migrated-table` command ([#729](#729)). * Allow specifying a group list when group match options are used ([#725](#725)). * Fixed installation issue when upgrading from an older version of the tool and improve logs ([#740](#740)). * Renamed summary panel from Failure Summary to Assessment Summary ([#733](#733)). * Retry internal error when getting permissions and update legacy table ACL documentation ([#728](#728)). * Speedup installer execution ([#727](#727)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #730: