Mount Point crawler lists /Volume with four variations which is confusing #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipankarkush-db
had a problem deploying
to
account-admin
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #779 +/- ##
=======================================
Coverage 82.87% 82.88%
=======================================
Files 39 39
Lines 4567 4569 +2
Branches 849 850 +1
=======================================
+ Hits 3785 3787 +2
Misses 580 580
Partials 202 202 ☔ View full report in Codecov by Sentry. |
dipankarkush-db
had a problem deploying
to
account-admin
GitHub Actions
Failure
dipankarkush-db
had a problem deploying
to
account-admin
GitHub Actions
Failure
dipankarkush-db
changed the title
dipankarkush-db
temporarily deployed
to
account-admin
GitHub Actions
Inactive
nfx
requested changes
Jan 13, 2024
| Mount(name="/Volume", source="DbfsReserved"), | ||
| Mount(name="/Volumes", source="DbfsReserved"), | ||
| Mount(name="/volume", source="DbfsReserved"), | ||
| Mount(name="/volumes", source="DbfsReserved"), |
There was a problem hiding this comment.
Add normal mount and assert it appears
| def test_list_mounts_should_return_a_deduped_list_of_mount_without_variable_volume_names(): | ||
| mounts = [ | ||
| Mount(name="/Volume", source="DbfsReserved"), | ||
| Mount(name="/Volumes", source="DbfsReserved"), |
There was a problem hiding this comment.
Can we just filter out dbfs reserved mounts instead?
There was a problem hiding this comment.
checked for DbfsReserved.
dipankarkush-db
temporarily deployed
to
account-admin
GitHub Actions
Inactive
FastLee
pushed a commit
that referenced
this pull request
Jan 19, 2024
nfx
added a commit
that referenced
this pull request
Jan 19, 2024
* Added `databricks labs ucx validate-groups-membership` command to validate groups to see if they have same membership across acount and workspace level ([#772](#772)). * Added baseline for getting Azure Resource Role Assignments ([#764](#764)). * Added issue and pull request templates ([#791](#791)). * Added linked issues to PR template ([#793](#793)). * Added optional `debug_truncate_bytes` parameter to the config and extend the default log truncation limit ([#782](#782)). * Added support for crawling grants and applying Hive Metastore UDF ACLs ([#812](#812)). * Changed Python requirement from 3.10.6 to 3.10 ([#805](#805)). * Extend error handling of delta issues in crawlers and hive metastore ([#795](#795)). * Fixed `databricks labs ucx repair-run` command to execute correctly ([#801](#801)). * Fixed handling of `DELTASHARING` table format ([#802](#802)). * Fixed listing of workflows via CLI ([#811](#811)). * Fixed logger import path for DEBUG notebook ([#792](#792)). * Fixed move table command to delete table/view regardless if permissions are present, skipping corrupted tables when crawling table size and making existing tests more stable ([#777](#777)). * Fixed the issue of `databricks labs ucx installations` and `databricks labs ucx manual-workspace-info` ([#814](#814)). * Increase the unit test coverage for cli.py ([#800](#800)). * Mount Point crawler lists /Volume with four variations which is confusing ([#779](#779)). * Updated README.md to remove mention of deprecated install.sh ([#781](#781)). * Updated `bug` issue template ([#797](#797)). * Fixed writing log readme in multiprocess safe way ([#794](#794)).
Merged
nfx
added a commit
that referenced
this pull request
Jan 19, 2024
* Added `databricks labs ucx validate-groups-membership` command to validate groups to see if they have same membership across acount and workspace level ([#772](#772)). * Added baseline for getting Azure Resource Role Assignments ([#764](#764)). * Added issue and pull request templates ([#791](#791)). * Added linked issues to PR template ([#793](#793)). * Added optional `debug_truncate_bytes` parameter to the config and extend the default log truncation limit ([#782](#782)). * Added support for crawling grants and applying Hive Metastore UDF ACLs ([#812](#812)). * Changed Python requirement from 3.10.6 to 3.10 ([#805](#805)). * Extend error handling of delta issues in crawlers and hive metastore ([#795](#795)). * Fixed `databricks labs ucx repair-run` command to execute correctly ([#801](#801)). * Fixed handling of `DELTASHARING` table format ([#802](#802)). * Fixed listing of workflows via CLI ([#811](#811)). * Fixed logger import path for DEBUG notebook ([#792](#792)). * Fixed move table command to delete table/view regardless if permissions are present, skipping corrupted tables when crawling table size and making existing tests more stable ([#777](#777)). * Fixed the issue of `databricks labs ucx installations` and `databricks labs ucx manual-workspace-info` ([#814](#814)). * Increase the unit test coverage for cli.py ([#800](#800)). * Mount Point crawler lists /Volume with four variations which is confusing ([#779](#779)). * Updated README.md to remove mention of deprecated install.sh ([#781](#781)). * Updated `bug` issue template ([#797](#797)). * Fixed writing log readme in multiprocess safe way ([#794](#794)).
dmoore247
pushed a commit
that referenced
this pull request
Mar 23, 2024
* Added `databricks labs ucx validate-groups-membership` command to validate groups to see if they have same membership across acount and workspace level ([#772](#772)). * Added baseline for getting Azure Resource Role Assignments ([#764](#764)). * Added issue and pull request templates ([#791](#791)). * Added linked issues to PR template ([#793](#793)). * Added optional `debug_truncate_bytes` parameter to the config and extend the default log truncation limit ([#782](#782)). * Added support for crawling grants and applying Hive Metastore UDF ACLs ([#812](#812)). * Changed Python requirement from 3.10.6 to 3.10 ([#805](#805)). * Extend error handling of delta issues in crawlers and hive metastore ([#795](#795)). * Fixed `databricks labs ucx repair-run` command to execute correctly ([#801](#801)). * Fixed handling of `DELTASHARING` table format ([#802](#802)). * Fixed listing of workflows via CLI ([#811](#811)). * Fixed logger import path for DEBUG notebook ([#792](#792)). * Fixed move table command to delete table/view regardless if permissions are present, skipping corrupted tables when crawling table size and making existing tests more stable ([#777](#777)). * Fixed the issue of `databricks labs ucx installations` and `databricks labs ucx manual-workspace-info` ([#814](#814)). * Increase the unit test coverage for cli.py ([#800](#800)). * Mount Point crawler lists /Volume with four variations which is confusing ([#779](#779)). * Updated README.md to remove mention of deprecated install.sh ([#781](#781)). * Updated `bug` issue template ([#797](#797)). * Fixed writing log readme in multiprocess safe way ([#794](#794)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
locations.pyfile in thedatabricks/labs/ucx/hive_metastoredirectory and the addition of a new unit test intest_locations.py. The changes inlocations.pyinvolve modifying the_deduplicate_mountsmethod in theMountsclass. The method now checks if the name of theMountobject contains the word "volume", and if so, it standardizes the name to "/Volume". This is done to ensure that mounts with different casing for the word "volume" are treated as the same mount and not duplicated in the deduplicated list.The new unit test in
test_locations.pyverifies that the_deduplicate_mountsmethod correctly deduplicates a list ofMountobjects with different casing for the word "volume" in their names. The test creates a list ofMountobjects with different casing for the word "volume" and passes it to the_deduplicate_mountsmethod. The test then asserts that the deduplicated list contains only oneMountobject with the name "/Volume". This test ensures that the changes to the_deduplicate_mountsmethod work as intended and prevent duplication of mounts with different casing for the word "volume" in their names.In summary, the changes in this pull request modify the
_deduplicate_mountsmethod to standardize the name of mounts containing the word "volume" and add a unit test to ensure that the method correctly deduplicates a list ofMountobjects with different casing for the word "volume" in their names.