Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added databricks labs ucx alias command to create a view of tables from one schema/catalog in another schema/catalog #837

Merged
merged 15 commits into from
Jan 26, 2024
Merged

Added databricks labs ucx alias command to create a view of tables from one schema/catalog in another schema/catalog #837

merged 15 commits into from
Jan 26, 2024

Conversation

FastLee
Copy link
Contributor

@FastLee FastLee commented Jan 24, 2024

Changes

Linked issues

closes #676

Resolves #..

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs ucx ...
  • added a new workflow
  • modified existing workflow: ...
  • added a new table
  • modified existing table: ...

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • verified on staging environment (screenshot attached)

@codecov Codecov
Copy link

codecov bot commented Jan 24, 2024 •
edited
Loading

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (ae54f76) 85.61% compared to head (f307efa) 85.63%.
Report is 1 commits behind head on main.

Files Patch % Lines
...atabricks/labs/ucx/hive_metastore/table_migrate.py 81.25% 7 Missing and 5 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
+ Coverage   85.61%   85.63%   +0.02%     
==========================================
  Files          41       41              
  Lines        5212     5296      +84     
  Branches      950      965      +15     
==========================================
+ Hits         4462     4535      +73     
- Misses        536      543       +7     
- Partials      214      218       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FastLee FastLee marked this pull request as ready for review January 24, 2024 21:25
@FastLee FastLee requested review from a team, larsgeorge-db and nfx and removed request for larsgeorge-db January 24, 2024 21:25
nfx
nfx requested changes Jan 25, 2024
View reviewed changes
src/databricks/labs/ucx/assessment/clusters.py Outdated Show resolved Hide resolved
labs.yml Show resolved Hide resolved
src/databricks/labs/ucx/cli.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/table_migrate.py Outdated Show resolved Hide resolved
tests/unit/hive_metastore/test_table_move.py Outdated Show resolved Hide resolved
@nfx nfx changed the title Added databricks labs ucx alias-tables command to create a view of tables from one schema/catalog in another schema/catalog Added databricks labs ucx alias command to create a view of tables from one schema/catalog in another schema/catalog Jan 25, 2024
@FastLee FastLee requested a review from nfx January 25, 2024 22:42
nfx
nfx approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nfx nfx merged commit 44ad51c into main Jan 26, 2024
7 checks passed
@nfx nfx deleted the feature/cli_alias_676 branch January 26, 2024 10:30
nfx added a commit that referenced this pull request Jan 26, 2024
@nfx
Release v0.11.0
f195a43 
* Added `databricks labs ucx alias` command to create a view of tables from one schema/catalog in another schema/catalog ([#837](#837)).
* Added `databricks labs ucx save-aws-iam-profiles` command to scan instance profiles identify AWS S3 access and save a CSV with permissions ([#817](#817)).
* Added total view counts in the assessment dashboard ([#834](#834)).
* Cleaned up `assess_jobs` and `assess_clusters` tasks in the `assessment` workflow to improve testing and reduce redundancy.([#825](#825)).
* Added documentation for the assessment report ([#806](#806)).
* Fixed escaping for SQL object names ([#836](#836)).

Dependency updates:

 * Updated databricks-sdk requirement from ~=0.17.0 to ~=0.18.0 ([#832](#832)).
@nfx nfx mentioned this pull request Jan 26, 2024
Merged
nfx added a commit that referenced this pull request Jan 26, 2024
@nfx
Release v0.11.0 (#848)
606dd72 
* Added `databricks labs ucx alias` command to create a view of tables
from one schema/catalog in another schema/catalog
([#837](#837)).
* Added `databricks labs ucx save-aws-iam-profiles` command to scan
instance profiles identify AWS S3 access and save a CSV with permissions
([#817](#817)).
* Added total view counts in the assessment dashboard
([#834](#834)).
* Cleaned up `assess_jobs` and `assess_clusters` tasks in the
`assessment` workflow to improve testing and reduce
redundancy.([#825](#825)).
* Added documentation for the assessment report
([#806](#806)).
* Fixed escaping for SQL object names
([#836](#836)).

Dependency updates:

* Updated databricks-sdk requirement from ~=0.17.0 to ~=0.18.0
([#832](#832)).
dmoore247 pushed a commit that referenced this pull request Mar 23, 2024
@FastLee @dmoore247
Added databricks labs ucx alias command to create a view of tables …
26a5be4 
…from one schema/catalog in another schema/catalog (#837)
dmoore247 pushed a commit that referenced this pull request Mar 23, 2024
@nfx @dmoore247
Release v0.11.0 (#848)
cc95dfc 
* Added `databricks labs ucx alias` command to create a view of tables
from one schema/catalog in another schema/catalog
([#837](#837)).
* Added `databricks labs ucx save-aws-iam-profiles` command to scan
instance profiles identify AWS S3 access and save a CSV with permissions
([#817](#817)).
* Added total view counts in the assessment dashboard
([#834](#834)).
* Cleaned up `assess_jobs` and `assess_clusters` tasks in the
`assessment` workflow to improve testing and reduce
redundancy.([#825](#825)).
* Added documentation for the assessment report
([#806](#806)).
* Fixed escaping for SQL object names
([#836](#836)).

Dependency updates:

* Updated databricks-sdk requirement from ~=0.17.0 to ~=0.18.0
([#832](#832)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfx nfx nfx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add databricks labs ucx alias command
2 participants
@FastLee @nfx