-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup install documentation #951
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HariGS-DB
had a problem deploying
to
account-admin
February 15, 2024 21:31
— with
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #951 +/- ##
=======================================
Coverage 87.92% 87.92%
=======================================
Files 43 43
Lines 5178 5178
Branches 928 928
=======================================
Hits 4553 4553
Misses 428 428
Partials 197 197 ☔ View full report in Codecov by Sentry. |
HariGS-DB
requested review from
a team,
priyal-c and
nfx
and removed request for
priyal-c
February 15, 2024 21:33
HariGS-DB
had a problem deploying
to
account-admin
February 15, 2024 21:58
— with
GitHub Actions
Failure
nfx
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
nfx
added a commit
that referenced
this pull request
Feb 16, 2024
* Added CLI Command `databricks labs ucx principal-prefix-access` ([#949](#949)). * Added a widget with all jobs to track migration progress ([#940](#940)). * Added legacy cluster types to the assessment result ([#932](#932)). * Cleanup of install documentation ([#951](#951), [#947](#947)). * Fixed `WorkspaceConfig` initialization for `DEBUG` notebook ([#934](#934)). * Fixed installer not opening config file during the installation ([#945](#945)). * Fixed groups in config file not considered for group migration job ([#943](#943)). * Fixed bug where `tenant_id` inside secret scope is not detected ([#942](#942)).
Merged
nfx
added a commit
that referenced
this pull request
Feb 16, 2024
* Added CLI Command `databricks labs ucx principal-prefix-access` ([#949](#949)). * Added a widget with all jobs to track migration progress ([#940](#940)). * Added legacy cluster types to the assessment result ([#932](#932)). * Cleanup of install documentation ([#951](#951), [#947](#947)). * Fixed `WorkspaceConfig` initialization for `DEBUG` notebook ([#934](#934)). * Fixed installer not opening config file during the installation ([#945](#945)). * Fixed groups in config file not considered for group migration job ([#943](#943)). * Fixed bug where `tenant_id` inside secret scope is not detected ([#942](#942)).
dmoore247
pushed a commit
that referenced
this pull request
Mar 23, 2024
## Changes This PR removes the gif showing old method of install UCX using install.sh. Also updating the Readme to show the new method to install Windows and added new image ### Functionality - [X] added relevant user documentation - [ ] added new CLI command - [ ] modified existing command: `databricks labs ucx ...` - [ ] added a new workflow - [ ] modified existing workflow: `...` - [ ] added a new table - [ ] modified existing table: `...` ### Tests - [ ] manually tested - [ ] added unit tests - [ ] added integration tests - [ ] verified on staging environment (screenshot attached)
dmoore247
pushed a commit
that referenced
this pull request
Mar 23, 2024
* Added CLI Command `databricks labs ucx principal-prefix-access` ([#949](#949)). * Added a widget with all jobs to track migration progress ([#940](#940)). * Added legacy cluster types to the assessment result ([#932](#932)). * Cleanup of install documentation ([#951](#951), [#947](#947)). * Fixed `WorkspaceConfig` initialization for `DEBUG` notebook ([#934](#934)). * Fixed installer not opening config file during the installation ([#945](#945)). * Fixed groups in config file not considered for group migration job ([#943](#943)). * Fixed bug where `tenant_id` inside secret scope is not detected ([#942](#942)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR removes the gif showing old method of install UCX using install.sh. Also updating the Readme to show the new method to install Windows and added new image
Functionality
databricks labs ucx ...
...
...
Tests