Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup install documentation #951

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Cleanup install documentation #951

merged 2 commits into from
Feb 15, 2024

Conversation

HariGS-DB
Copy link
Contributor

Changes

This PR removes the gif showing old method of install UCX using install.sh. Also updating the Readme to show the new method to install Windows and added new image

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs ucx ...
  • added a new workflow
  • modified existing workflow: ...
  • added a new table
  • modified existing table: ...

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • verified on staging environment (screenshot attached)

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1173b7) 87.92% compared to head (0aaf32b) 87.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #951   +/-   ##
=======================================
  Coverage   87.92%   87.92%           
=======================================
  Files          43       43           
  Lines        5178     5178           
  Branches      928      928           
=======================================
  Hits         4553     4553           
  Misses        428      428           
  Partials      197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HariGS-DB HariGS-DB marked this pull request as ready for review February 15, 2024 21:33
@HariGS-DB HariGS-DB requested review from a team, priyal-c and nfx and removed request for priyal-c February 15, 2024 21:33
Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx changed the title Updating ReadMe documentation Cleanup install documentation Feb 15, 2024
@nfx nfx merged commit 2e003a2 into main Feb 15, 2024
6 of 7 checks passed
@nfx nfx deleted the feature/updatedocs branch February 15, 2024 22:36
nfx added a commit that referenced this pull request Feb 16, 2024
* Added CLI Command `databricks labs ucx principal-prefix-access` ([#949](#949)).
* Added a widget with all jobs to track migration progress ([#940](#940)).
* Added legacy cluster types to the assessment result ([#932](#932)).
* Cleanup of install documentation ([#951](#951), [#947](#947)).
* Fixed `WorkspaceConfig` initialization for `DEBUG` notebook ([#934](#934)).
* Fixed installer not opening config file during the installation ([#945](#945)).
* Fixed groups in config file not considered for group migration job ([#943](#943)).
* Fixed bug where `tenant_id` inside secret scope is not detected ([#942](#942)).
@nfx nfx mentioned this pull request Feb 16, 2024
nfx added a commit that referenced this pull request Feb 16, 2024
* Added CLI Command `databricks labs ucx principal-prefix-access`
([#949](#949)).
* Added a widget with all jobs to track migration progress
([#940](#940)).
* Added legacy cluster types to the assessment result
([#932](#932)).
* Cleanup of install documentation
([#951](#951),
[#947](#947)).
* Fixed `WorkspaceConfig` initialization for `DEBUG` notebook
([#934](#934)).
* Fixed installer not opening config file during the installation
([#945](#945)).
* Fixed groups in config file not considered for group migration job
([#943](#943)).
* Fixed bug where `tenant_id` inside secret scope is not detected
([#942](#942)).
dmoore247 pushed a commit that referenced this pull request Mar 23, 2024
## Changes
This PR removes the gif showing old method of install UCX using
install.sh. Also updating the Readme to show the new method to install
Windows and added new image


### Functionality 

- [X] added relevant user documentation
- [ ] added new CLI command
- [ ] modified existing command: `databricks labs ucx ...`
- [ ] added a new workflow
- [ ] modified existing workflow: `...`
- [ ] added a new table
- [ ] modified existing table: `...`

### Tests


- [ ] manually tested
- [ ] added unit tests
- [ ] added integration tests
- [ ] verified on staging environment (screenshot attached)
dmoore247 pushed a commit that referenced this pull request Mar 23, 2024
* Added CLI Command `databricks labs ucx principal-prefix-access`
([#949](#949)).
* Added a widget with all jobs to track migration progress
([#940](#940)).
* Added legacy cluster types to the assessment result
([#932](#932)).
* Cleanup of install documentation
([#951](#951),
[#947](#947)).
* Fixed `WorkspaceConfig` initialization for `DEBUG` notebook
([#934](#934)).
* Fixed installer not opening config file during the installation
([#945](#945)).
* Fixed groups in config file not considered for group migration job
([#943](#943)).
* Fixed bug where `tenant_id` inside secret scope is not detected
([#942](#942)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants