Fixed installer script to reuse an existing UCX Cluster policy if present #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HariGS-DB
had a problem deploying
to
account-admin
GitHub Actions
Failure
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #964 +/- ##
==========================================
+ Coverage 87.49% 87.53% +0.04%
==========================================
Files 44 44
Lines 5319 5337 +18
Branches 949 954 +5
==========================================
+ Hits 4654 4672 +18
Misses 450 450
Partials 215 215 ☔ View full report in Codecov by Sentry. |
nfx
requested changes
Feb 21, 2024
HariGS-DB
had a problem deploying
to
account-admin
GitHub Actions
Failure
HariGS-DB
requested review from
nfx
and removed request for
andrascsillag-db
nfx
changed the title
nfx
added a commit
that referenced
this pull request
Feb 21, 2024
* Added secret detection logic to Azure service principal crawler ([#950](#950)). * Create storage credentials based on instance profiles and existing roles ([#869](#869)). * Enforced `protected-access` pylint rule ([#956](#956)). * Enforced `pylint` on unit and integration test code ([#953](#953)). * Enforcing `invalid-name` pylint rule ([#957](#957)). * Fixed AzureResourcePermissions.load to call Installation.load ([#962](#962)). * Fixed installer script to reuse an existing UCX Cluster policy if present ([#964](#964)). * More `pylint` tuning ([#958](#958)). * Refactor `workspace_client_mock` to have combine fixtures stored in separate JSON files ([#955](#955)). Dependency updates: * Updated databricks-sdk requirement from ~=0.19.0 to ~=0.20.0 ([#961](#961)).
Merged
nfx
added a commit
that referenced
this pull request
Feb 21, 2024
* Added secret detection logic to Azure service principal crawler ([#950](#950)). * Create storage credentials based on instance profiles and existing roles ([#869](#869)). * Enforced `protected-access` pylint rule ([#956](#956)). * Enforced `pylint` on unit and integration test code ([#953](#953)). * Enforcing `invalid-name` pylint rule ([#957](#957)). * Fixed AzureResourcePermissions.load to call Installation.load ([#962](#962)). * Fixed installer script to reuse an existing UCX Cluster policy if present ([#964](#964)). * More `pylint` tuning ([#958](#958)). * Refactor `workspace_client_mock` to have combine fixtures stored in separate JSON files ([#955](#955)). Dependency updates: * Updated databricks-sdk requirement from ~=0.19.0 to ~=0.20.0 ([#961](#961)).
dmoore247
pushed a commit
that referenced
this pull request
Mar 23, 2024
…sent (#964) ## Changes This change fixes two bugs related to cluster policy setup during ucx installation - If a user is rerunning installation (due to some issue previously but some steps completed like policy creation), if a UCX cluster policy is found, it reuses that instead of creating one - If the user is upgrading UCX where the initial installation steps are skipped, but the policy ID is not found in the config.yaml (due to manually deleting or upgrading from an older version), then raise an InvalidParameterValue with a custom msg saying policy id not found and request the user to uninstall and reinstall ucx completely. ### #963 ### Functionality - [ ] added relevant user documentation - [ ] added new CLI command - [ ] modified existing command: `databricks labs ucx ...` - [ ] added a new workflow - [ ] modified existing workflow: `...` - [ ] added a new table - [ ] modified existing table: `...` ### Tests - [X] manually tested - [X] added unit tests - [X] added integration tests - [ ] verified on staging environment (screenshot attached)
dmoore247
pushed a commit
that referenced
this pull request
Mar 23, 2024
* Added secret detection logic to Azure service principal crawler ([#950](#950)). * Create storage credentials based on instance profiles and existing roles ([#869](#869)). * Enforced `protected-access` pylint rule ([#956](#956)). * Enforced `pylint` on unit and integration test code ([#953](#953)). * Enforcing `invalid-name` pylint rule ([#957](#957)). * Fixed AzureResourcePermissions.load to call Installation.load ([#962](#962)). * Fixed installer script to reuse an existing UCX Cluster policy if present ([#964](#964)). * More `pylint` tuning ([#958](#958)). * Refactor `workspace_client_mock` to have combine fixtures stored in separate JSON files ([#955](#955)). Dependency updates: * Updated databricks-sdk requirement from ~=0.19.0 to ~=0.20.0 ([#961](#961)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change fixes two bugs related to cluster policy setup during ucx installation
#963
Functionality
databricks labs ucx .........Tests