Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for 282 #287

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Patch for 282 #287

merged 3 commits into from
Oct 3, 2024

Conversation

JasonJWilliamsNY
Copy link
Contributor

Adding a warning in response to issue #282

Copy link

github-actions bot commented Oct 2, 2024

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

Results of any additional workflows will appear here when they are done.

@@ -114,6 +114,14 @@ http://ec2.12.2.45.678.compute-1.amazonaws.com:8787

::::::::::::::::::::::::::::::::::::::::: callout

## Warning: Browser and VPN usage

The AWS link may not work for some browsers (e.g. Microsoft Edge). For those browsers, you may need to copy link and paste into browser instead of clicking link in spreadsheet. Also, if you are using a VPN, you may need to disconnect in order to reach the server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might revise the second sentence to "For those browsers, you may need to copy the link and paste it into your browser instead of clicking the link in the spreadsheet."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the fix.

@naupaka naupaka merged commit b515d1a into datacarpentry:main Oct 3, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 3, 2024
Auto-generated via {sandpaper}
Source  : b515d1a
Branch  : main
Author  : Naupaka Zimmerman <naupaka@gmail.com>
Time    : 2024-10-03 18:14:46 +0000
Message : Merge pull request #287 from JasonJWilliamsNY/patch-for-282

Patch for 282
github-actions bot pushed a commit that referenced this pull request Oct 3, 2024
Auto-generated via {sandpaper}
Source  : 16d49ba
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-10-03 18:15:53 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : b515d1a
Branch  : main
Author  : Naupaka Zimmerman <naupaka@gmail.com>
Time    : 2024-10-03 18:14:46 +0000
Message : Merge pull request #287 from JasonJWilliamsNY/patch-for-282

Patch for 282
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
Auto-generated via {sandpaper}
Source  : 16d49ba
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-10-03 18:15:53 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : b515d1a
Branch  : main
Author  : Naupaka Zimmerman <naupaka@gmail.com>
Time    : 2024-10-03 18:14:46 +0000
Message : Merge pull request #287 from JasonJWilliamsNY/patch-for-282

Patch for 282
github-actions bot pushed a commit that referenced this pull request Oct 15, 2024
Auto-generated via `{sandpaper}`
Source  : 16d49ba
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-10-03 18:15:53 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : b515d1a
Branch  : main
Author  : Naupaka Zimmerman <naupaka@gmail.com>
Time    : 2024-10-03 18:14:46 +0000
Message : Merge pull request #287 from JasonJWilliamsNY/patch-for-282

Patch for 282
github-actions bot pushed a commit that referenced this pull request Oct 17, 2024
Auto-generated via `{sandpaper}`
Source  : 16d49ba
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-10-03 18:15:53 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : b515d1a
Branch  : main
Author  : Naupaka Zimmerman <naupaka@gmail.com>
Time    : 2024-10-03 18:14:46 +0000
Message : Merge pull request #287 from JasonJWilliamsNY/patch-for-282

Patch for 282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants