update the dns module to the version of cosmos-sdk v0.40.0-rc3 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshihiko-okubo
force-pushed
the
update_to_stargate
branch
2 times, most recently
from
2c8e2d2
to
50c4a2f
Compare
toshihiko-okubo
changed the title
toshihiko-okubo
changed the title
toshihiko-okubo
force-pushed
the
update_to_stargate
branch
7 times, most recently
from
c55e129
to
06a66f5
Compare
toshihiko-okubo
force-pushed
the
update_to_stargate
branch
3 times, most recently
from
3d061b2
to
a355bce
Compare
toshihiko-okubo
force-pushed
the
update_to_stargate
branch
3 times, most recently
from
45fcee7
to
c5d4bc9
Compare
toshihiko-okubo
force-pushed
the
update_to_stargate
branch
from
c5d4bc9
to
7dceece
Compare
toshihiko-okubo
commented
Nov 12, 2020
| func (p RegisterDomainPacketData) GetTimeoutHeight() uint64 { | ||
| return math.MaxUint64 | ||
| func (p RegisterDomainPacketData) GetTimeoutHeight() ibcclienttypes.Height { | ||
| return ibcclienttypes.NewHeight(0, math.MaxInt64) |
There was a problem hiding this comment.
If MaxUint64 is specified, Overflow may occur with the following Code
https://github.com/cosmos/cosmos-sdk/blob/master/x/ibc/core/02-client/types/height.go#L61
There was a problem hiding this comment.
I've fixed it at this commit.
After a new version that includes this commit is released, we should revert the changes.
toshihiko-okubo
force-pushed
the
update_to_stargate
branch
from
356be64
to
441d089
Compare
toshihiko-okubo
force-pushed
the
update_to_stargate
branch
from
441d089
to
ca3b663
Compare
bluele
reviewed
Nov 18, 2020
There was a problem hiding this comment.
@toshihiko-okubo
The implementation looks good!
I have two suggestions:
- Can you move
x/ibc-dns/testingdirectory to underx/ibc? This is because we want to separate ibc testing module from dns package. - And sorry, can you use the SDK version v0.40.3-rc-3?
toshihiko-okubo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.