feat: add array and struct field management in glue importer #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massilchabane
approved these changes
Jun 19, 2024
|
Great contribution. LGTM. |
|
Please check the test results |
oops I made some typos in my test case and expected result, I fixed them |
|
Merged, again, thanks for your contribution. Do you need are quick release for this feature? |
Thanks a lot ! |
|
@pierre-monnet can you provide a CHANGELOG entry, please? Perhaps in another PR? |
No problem, I'll work on it |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now when Glue table contains array or struct field, it is returned as "variant" and items or subfields aren't retrieve.