Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update duckdb.py for s3 connection by utilizing session_token for short term credentials #309

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

masoodkhalid32
Copy link
Contributor

S3 connection would not work with only access_key_id and secret_access_key if it short_term_credentials. adding session _token in the connection setup for s3 with short term credentials.

  • Tests pass
  • ruff format
  • README.md updated (if relevant)
  •  CHANGELOG.md entry added

S3 connection would not work with only access_key_id and secret_access_key if it short_term_credentials. adding session _token in the connection setup for s3 with short term credentials.
@jochenchrist
Copy link
Contributor

Thanks for your contribution.

@jochenchrist jochenchrist merged commit ff00fb5 into datacontract:main Jul 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants