-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/311: Add enum and map type for avro schema #324
Fix/311: Add enum and map type for avro schema #324
Conversation
There currently is no @jochenchrist three options:
Not sure where we should be heading. Any thoughts? |
Created datacontract/datacontract-specification#80 to discuss map |
@jochenchrist Correct me if I am wrong, but I don't see any discussion about enum type. Should I raise a PR to also add |
Regarding |
Like this:
|
5ee440e
to
4104c19
Compare
4104c19
to
5384d08
Compare
5384d08
to
2a146c5
Compare
@jochenchrist I have made appropriate changes to accommodate |
…nd-map-type-for-avro-schema # Conflicts: # CHANGELOG.md # tests/fixtures/avro/data/orders.avsc
Thank you for your contribution. We added official support for Maps to the specification. 🎉 |
I also updated the code, resolved merge conflicts, and removed the workaround in datacontract/lint/schema.py |
Thank you @jochenchrist, Looking forward to do more contributions 👍 |
Resolves issue #311
This PR adds enum and map type logic to the import avro_importer.py, resolving import errors.