Fixes our failing dependency checks #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifier had blank lines at the end, so strip the string of all the blank space. Also optimizes for only reading in the last 512 bytes instead of loading a possibly huge entire huge log file into memory and an array.
|
Looks good, and fixes the problem on dev. Thanks for tracking this down! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OAI server moved and the Notifier had blank lines at the end of the log, so the last line always being a date isn't great assumption.
if there is whitespace at the end, strip the string of all the blank space. Also optimizes for only reading in the last 512 bytes instead of loading a possibly huge entire huge log file into memory and an array just check the last line.