fix: additional checks of readme editor files #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is fine, though I'm not certain it solve the full problem. I can rename a PDF file with a .txt extension, and I'm allowed to import it, though the results are less than stellar. |
|
It's hard to solve any "problem" of requiring or verifying specific mimetypes for anything entirely in the front end like this. We are trying to tell people how to do things corectly, but if there are people who really want their READMEs to look awful it's very difficult to stop them! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes datadryad/dryad-product-roadmap#3359
Closes datadryad/dryad-product-roadmap#3345