feat: upgrade Node & webpacker (shakapacker) #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is deployed on dev. Once it's merged, I will begin the Ruby and Rails upgrade as well. |
|
Looks good, and works fine for me. One note, I see the following warning: " > shakapacker@6.6.0" has incorrect peer dependency "webpack-dev-server@^4.9.0". Should we delete this dependency? |
This is because shakapacker is asking for webpack-dev-server v4.9.0, but we're actually using webpack-dev-server version 5(something). After testing showed no problems I decided to keep using the newer version against shakapacker's wishes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes datadryad/dryad-product-roadmap#3314
Closes datadryad/dryad-product-roadmap#3152
v20.13.1 of Node will need to be installed on the servers & used in the .bashrc file to deploy