Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase size limit of files to use with Frictionless to 50MB #1711

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

ryscher
Copy link
Member

@ryscher ryscher commented Jun 18, 2024

Based on testing in datadryad/dryad-product-roadmap#2880, we are updating the size of files to use with the Frictionless testing. New limits are 50MB for production and 1MB for test servers.

@ahamelers
Copy link
Collaborator

@ryscher Looking at the data, do you not think we could go up to 100MB?

@ryscher
Copy link
Member Author

ryscher commented Jun 18, 2024

I'm worried about whether submitters will actually wait for 4 minutes or more. But I'll defer to your judgement.

@ahamelers
Copy link
Collaborator

I'm worried about whether submitters will actually wait for 4 minutes or more. But I'll defer to your judgement.

If we allow it to run on even larger files, submitters can go ahead while it's still loading, but then eventually the curators could still see the errors. We could merge this for now and double check whether the curators think that is a good idea

@ahamelers ahamelers merged commit 2063559 into main Jun 18, 2024
5 checks passed
@ahamelers ahamelers deleted the frictionless-50mb branch June 25, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants