Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added withdrawn functionality and email notification, added final del… #1773

Merged
merged 21 commits into from
Oct 30, 2024

Conversation

alinvetian
Copy link
Contributor

@alinvetian alinvetian commented Jul 17, 2024

Closes: datadryad/dryad-product-roadmap#3378
Closes: datadryad/dryad-product-roadmap#3379
Closes: datadryad/dryad-product-roadmap#3392

Added new service for handling delete resource emails reminders
Added a rake task for easy access to these reminders
Added letter_opener gem for local environment
Added functionality to set resource as withdrawn and send an email notification
Added final email notification for withdrawn resources
Added option for admin users to change deletion calculation date

@alinvetian alinvetian marked this pull request as draft July 17, 2024 15:56
@alinvetian alinvetian changed the base branch from 3378-abandoned-datasets----monthly-reminders to main July 18, 2024 16:07
@alinvetian
Copy link
Contributor Author

The option to change the date is right under the activity log table and it changing it, generates an entry like the one from the image
image

@alinvetian alinvetian marked this pull request as ready for review August 28, 2024 14:57
Copy link
Collaborator

@ahamelers ahamelers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works as is, and I can refine the UI as I work on redesigning the activity log page (datadryad/dryad-product-roadmap#3534)

@ahamelers ahamelers requested a review from ryscher September 24, 2024 14:45
Copy link
Member

@ryscher ryscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still testing the functionality... will have more comments tomorrow.

app/mailers/stash_engine/resource_mailer.rb Outdated Show resolved Hide resolved
app/mailers/stash_engine/resource_mailer.rb Outdated Show resolved Hide resolved
app/mailers/stash_engine/resource_mailer.rb Outdated Show resolved Hide resolved
@ahamelers ahamelers requested a review from ryscher October 23, 2024 11:19
@ryscher
Copy link
Member

ryscher commented Oct 30, 2024

I was finally able to test all of this functionality, and it is working well. I updated the notes in https://docs.google.com/document/d/1D1d422Zk5YKbax_Hp92zIciu9m0dR7JmNDMoLMa92CY/edit?tab=t.0 so it is easier to see which rake tasks trigger each action.

Thanks Alin!!!!!

@ryscher ryscher merged commit 4fff5f0 into main Oct 30, 2024
5 checks passed
@ahamelers ahamelers deleted the 3379-abandoned-datasets----withdrawing branch October 31, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants