Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blackout check #1881

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Remove blackout check #1881

merged 1 commit into from
Oct 23, 2024

Conversation

ahamelers
Copy link
Collaborator

@ahamelers ahamelers requested a review from alinvetian October 22, 2024 11:54
@alinvetian
Copy link
Contributor

@ahamelers Currently in the database we have no Journal with allow_blackout: true and 187 with allow_blackout: nil
Do we still want to keep this flag? or we can do a code cleanup on this?

@ahamelers
Copy link
Collaborator Author

@alinvetian yes, I updated the journals in the database so these would no longer cause the curators problems while waiting for this PR. We don't usually delete now-unused fields from the database entirely (I'm not sure why not, exactly, and I've suggested it before. We can discuss in a dev meeting as there are a lot of them floating around!)

@alinvetian alinvetian merged commit 0582c05 into main Oct 23, 2024
5 checks passed
@alinvetian alinvetian deleted the blackout branch October 23, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve uncertainty about allow_blackout embargos
2 participants