Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for peer review email custom text #1898

Merged
merged 7 commits into from
Nov 11, 2024

Conversation

alinvetian
Copy link
Contributor

@alinvetian alinvetian commented Oct 29, 2024

Closes: datadryad/dryad-product-roadmap#3734

I also removed user_mailer views footer text since it is now in mailer layout

@alinvetian alinvetian requested a review from ryscher October 29, 2024 11:40
@ahamelers
Copy link
Collaborator

@alinvetian I don't think this should hold this from being merged or anything, but it might be better to make like a 'custom_email_text' table and link each journal to that—I learned with the tenant logos how annoying it could become to have potentially very long content like this on the main table.

Also, @ryscher is there any potential that other member types than journals would want to add custom email text in the future?

@alinvetian
Copy link
Contributor Author

@ahamelers I know having a separate table might be better, but at the moment we only have this simple customization. If we decide to do more custom emails in future I will update this field too, but there is no point at the moment

@ryscher ryscher merged commit 1b29973 into main Nov 11, 2024
5 checks passed
@ahamelers ahamelers deleted the 3734-acs-custom-email-text branch November 14, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACS: Custom email text
3 participants