This repository has been archived by the owner on May 17, 2024. It is now read-only.
Add version module and add version to tracking #327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The primary objective of this PR is to add data-diff version to tracking.
Detail / version module
However, when importing the
__version__
variable in thetracking.py
module, I ran into circular import errors. Circular references seemed to be related to imports in__init__.py
,__main__.py
, andtracking.py
. Both__init__.py
and__main__.py
import tracking viafrom .tracking import disable_tracking
.Errors were all some version of:
Rather than trying to disentangle the circular imports, I simply created a
version.py
module, and parked the__version__
variable there.Happy to revise this if there's a better path, or if I misunderstood errors. please let me know.
List of changes
version.py
module with__version__
__version__
from__init__.py
__main__.py
to usefrom .version import __version__
__version__
to track eventsEvent validation in Snowflake
Version is successfully coming through Rudderstack events
Python formatting
Formatting: