Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add computed expr for merge into #12905

Merged
merged 8 commits into from
Sep 19, 2023

Conversation

JackTan25
Copy link
Contributor

@JackTan25 JackTan25 commented Sep 19, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

for now, merge into doesn't support computed expr. we need to support it.
Summary about this PR


This change is Reviewable

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2023 10:54am

@JackTan25 JackTan25 marked this pull request as ready for review September 19, 2023 10:06
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Sep 19, 2023
Copy link
Member

@b41sh b41sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BohuTANG BohuTANG merged commit aa3d994 into datafuselabs:main Sep 19, 2023
66 of 67 checks passed
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
* add test first

* add computed expr for merge into

* fix check

* migrate test to ee

* Update 01_0001_computed_column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants