Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-4459: Add support for alter table rename statement #4532

Merged
merged 6 commits into from
Mar 22, 2022

Conversation

kevinw66
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Add support for alter table rename statement

Changelog

  • New Feature

Related Issues

Fixes #4459

Test Plan

Unit Tests

Stateless Tests

@vercel
Copy link

vercel bot commented Mar 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/3UPkBjpkQFqq1trYA5kXaCZDgwaR
✅ Preview: Canceled

[Deployment for 296dca0 canceled]

@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Mar 22, 2022
@kevinw66
Copy link
Contributor Author

@BohuTANG I saw stateless tests failed, but I can run in my local machine.
why?
image

@BohuTANG
Copy link
Member

[ FAIL ] - result differs with:
--- /Users/runner/work/databend/databend/tests/suites/0_stateless/05_ddl/05_0003_ddl_alter_table.result	2022-03-22 05:20:32.000000000 +0000
+++ /Users/runner/work/databend/databend/tests/suites/0_stateless/05_ddl/05_0003_ddl_alter_table.stdout	2022-03-22 05:26:41.000000000 +0000
@@ -1,2 +1,3 @@
 1
+ERROR 1105 (HY000) at line 10: Code: 1025, displayText = Unknown table 't0'.

I think t0 is a common name, some others test maybe use that? We can change it to a new unique name.

@BohuTANG
Copy link
Member

/lgtm

@BohuTANG BohuTANG merged commit ce01c74 into datafuselabs:main Mar 22, 2022
@kevinw66 kevinw66 deleted the alter_table_rename branch March 22, 2022 11:21
@BohuTANG BohuTANG mentioned this pull request May 12, 2022
55 tasks
@Xuanwo Xuanwo added this to the v0.8 milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ALTER TABLE [ IF EXISTS ] <name> RENAME TO <new_table_name>
5 participants