Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page up/down and move execution to normal mode #76

Merged
merged 4 commits into from
Apr 13, 2022

Conversation

matthewmturner
Copy link
Collaborator

@seryj FYI adding page up/down and i did try shift+enter but im having trouble with it(the KeyModifier::SHIFT isnt being recognized for some reason). will need to come back to it or table for now.

@matthewmturner
Copy link
Collaborator Author

Perhaps its unsupported by crossterm crossterm-rs/crossterm#400

@matthewmturner
Copy link
Collaborator Author

matthewmturner commented Apr 11, 2022

Alt(Option on mac)+Enter might be an option although that wouldnt align with other tools. What do you think @seryj?

@matthewmturner matthewmturner changed the title Page up/down and shift-enter Page up/down Apr 11, 2022
@seryj
Copy link
Contributor

seryj commented Apr 11, 2022

For me, it's an absolutely acceptable solution. I mean, yes, it does not align with other tools... but you know: how many other terminal UI tools for data analysis do exist?! At least out off my head I can call exactly zero. Having such a tool is really a big gain and such small differences really do not play a big role.
At least, I see it this way. And if at some point people really start using this tool extensively, there will be solution for other key bindings.

@matthewmturner
Copy link
Collaborator Author

Man even alt enter is giving me lots of issues. Been digging through other peoples hacks but still not getting the key combination recognized. i think i will just have execution via normal mode for now and come back to this.

@matthewmturner
Copy link
Collaborator Author

well i think i got a baseline interface down to execute with enter from normal mode. not ideal but i think good enough for 0.1. i really want to get alt+enter or something of the sort supported though in the next release.

@matthewmturner matthewmturner changed the title Page up/down Page up/down and move execution to normal mode Apr 12, 2022
@matthewmturner matthewmturner merged commit df608c7 into datafusion-contrib:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error message for invalid sql statements Add commands in normal mode to scroll faster
2 participants