feat: add support for converting LargeUtf8/LargeString in try_cast_to #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2024
phillipleblanc
approved these changes
Oct 22, 2024
|
@phillipleblanc Thank you for your review and valuable feedback! 😊 I have made the necessary changes based on your suggestions. Please let me know if there's anything else that needs adjustment. Thanks again for your time and help, and I look forward to the merge! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue in the MySQL implementation within the datafusion-table-providers project. In the MySQL implementation, varchar and json types are mapped to DataFusion's LargeUtf8 type, corresponding to the LargeString data type. In the test code of datafusion-table-providers, the try_cast_to function is used to convert the record batch from a query according to the schema used during table creation. However, the previous version only supported String and could not convert record batches from MySQL where json uses LargeString. This PR adds support for LargeString to enable the conversion of such record batches.