feat: PEP-621 standard Python project metadata #143
Conversation
bolinocroustibat
force-pushed
the
pep-standard-pyproject
branch
from
05f130c
to
bf32bfc
Compare
bolinocroustibat
force-pushed
the
pep-standard-pyproject
branch
6 times, most recently
from
e3051e3
to
949a72a
Compare
bolinocroustibat
force-pushed
the
pep-standard-pyproject
branch
2 times, most recently
from
2ba6f13
to
1ffe9e2
Compare
bolinocroustibat
force-pushed
the
pep-standard-pyproject
branch
7 times, most recently
from
4748c9e
to
0faa942
Compare
bolinocroustibat
changed the title
bolinocroustibat
force-pushed
the
pep-standard-pyproject
branch
3 times, most recently
from
9fdd413
to
7637389
Compare
bolinocroustibat
changed the title
bolinocroustibat
force-pushed
the
pep-standard-pyproject
branch
from
854450b
to
c4c7a3c
Compare
There was a problem hiding this comment.
After this PR, we need to check if there is any usage of poetry in our current infra since it may have been used to install the hydra.
.pre-commit-config.yaml
Outdated
There was a problem hiding this comment.
We may want to add a pre-commit to generate the requirements lock files.
See for example the logic on udata side: https://github.com/opendatateam/udata/blob/a83b29a6516b3ededda7d797fb004f4d1eede2fa/.pre-commit-config.yaml#L3
| ...or `pip-sync requirements-dev.txt` with [pip-tools](https://pip-tools.readthedocs.io/en/stable/). | ||
|
|
||
| To update the lock files, you can use any modern Python package manager (except Poetry) like [pip-tools](https://pip-tools.readthedocs.io/en/stable/), [PDM](https://pdm.fming.dev/) or [uv](https://uv.readthedocs.io/en/latest/), while defining `requirement.txt` and `requirement-dev.txt` as the output lock files. | ||
| With [pip-tools](https://pip-tools.readthedocs.io/en/stable/), the commands are `pip-compile` for requirements.txt, and `pip-compile --extra dev -o requirements-dev.txt` for requirements-dev.txt. |
There was a problem hiding this comment.
Do we need to specify the constraint to compile dev deps with requirements.txt? Or is it already implicit with the way --extra works? Ex adding -c requirements.txt.
We don't want a version to diverge between requirements.txt and requirements-dev.txt.
| udata-hydra = "udata_hydra.cli:run" | ||
| udata-hydra-crawl = "udata_hydra.crawl:run" | ||
| udata-hydra-app = "udata_hydra.app:run" |
There was a problem hiding this comment.
After this PR, we must check if these scripts were used in our infra
.circleci/config.yml
Outdated
| @@ -84,17 +89,29 @@ jobs: | |||
| steps: | |||
| - attach_workspace: | |||
| at: . | |||
| - run: | |||
| name: Install build dependencies, not including dev ones | |||
There was a problem hiding this comment.
Why do we need to reinstall venv here?
.circleci/config.yml
Outdated
| pip install --upgrade pip | ||
| python3 -m venv .venv_build && source .venv_build/bin/activate | ||
| pip install -r requirements.txt | ||
| pip install build |
There was a problem hiding this comment.
Do we prefer using build or pip-wheel? I'm unsure which one to prefer reading https://pip.pypa.io/en/stable/cli/pip_wheel/#differences-to-build.
# Conflicts: # pyproject.toml
Co-authored-by: Mathieu Agopian <mathieu@agopian.info>
Co-authored-by: maudetes <maudet.estelle@gmail.com>
bolinocroustibat
force-pushed
the
pep-standard-pyproject
branch
from
e3c44b6
to
5e93dc8
Compare
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
Closes #145 by:
pyproject.tomlto become a package-manager agnostic project filerequirements.txtandrequirements-dev.txtfiles frompyproject.tomlPython project fileQuestion: do we want to include dependencies hashes in the lock dependencies files? Can be done with
pip-compile --generate-hashespyproject.tomlso that when CI adds dev version, it is a PEP440 compatible