Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): exclude mssql-odbc from "all" extra #2660

Merged
merged 1 commit into from
Jun 7, 2021
Merged

fix(ingest): exclude mssql-odbc from "all" extra #2660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docker/datahub-ingestion/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ RUN apt-get update && apt-get install -y \

FROM openjdk:8 as prod-build
COPY . /datahub-src
RUN cd /datahub-src && ./gradlew :metadata-events:mxe-schemas:build
# RUN cd /datahub-src && ./gradlew :metadata-events:mxe-schemas:build

FROM base as prod-codegen
COPY --from=prod-build /datahub-src /datahub-src
RUN cd /datahub-src/metadata-ingestion && \
pip install -e ".[base]" && \
./scripts/codegen.sh
# RUN cd /datahub-src/metadata-ingestion && \
# pip install -e ".[base]" && \
# ./scripts/codegen.sh

FROM base as prod-install
COPY --from=prod-codegen /datahub-src/metadata-ingestion /datahub-ingestion
Expand Down
16 changes: 15 additions & 1 deletion metadata-ingestion/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,12 @@ def get_long_description():
"glue": {"boto3"},
}

all_exclude_plugins: Set[str] = {
# SQL Server ODBC requires additional drivers, and so we don't want to keep
# it included in the default "all" installation.
"mssql-odbc",
}

base_dev_requirements = {
*base_requirements,
*framework_common,
Expand Down Expand Up @@ -234,7 +240,15 @@ def get_long_description():
plugin: list(framework_common | dependencies)
for (plugin, dependencies) in plugins.items()
},
"all": list(framework_common.union(*plugins.values())),
"all": list(
framework_common.union(
*[
requirements
for plugin, requirements in plugins.items()
if plugin not in all_exclude_plugins
]
)
),
"dev": list(dev_requirements),
"dev-airflow2": list(dev_requirements_airflow_2),
},
Expand Down