Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate dkulib & allow empty input #9

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Integrate dkulib & allow empty input #9

wants to merge 5 commits into from

Conversation

Muennighoff
Copy link

@Muennighoff Muennighoff commented Jan 5, 2023 •
edited
Loading

Fixes #8 & adds dkulib 😇

Note: Tests are failing as they have been removed.

@Muennighoff Muennighoff self-assigned this Jan 5, 2023
mhham
mhham reviewed Jan 5, 2023
View reviewed changes
Copy link

@mhham mhham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm, did not test the plugin yet.

Also could you point me to the part that allows empty input ?

@Muennighoff
Copy link
Author

Code lgtm, did not test the plugin yet.

Also could you point me to the part that allows empty input ?

Nice let me know if you want me to send you my API Key! It works by default thanks to the new parallelizer :)

mhham
mhham reviewed Jan 6, 2023
View reviewed changes
Copy link

@mhham mhham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine locally.

Pending CI failure investigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhham mhham mhham left review comments

@nicolasdalsass nicolasdalsass Awaiting requested review from nicolasdalsass

At least 1 approving review is required to merge this pull request.

Assignees

@Muennighoff Muennighoff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty dataset throws an error
2 participants
@Muennighoff @mhham