Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use predicate to filter out CR Specs NOT to be reconciled #4

Closed
AdheipSingh opened this issue Feb 21, 2023 · 3 comments · Fixed by #31
Closed

Use predicate to filter out CR Specs NOT to be reconciled #4

AdheipSingh opened this issue Feb 21, 2023 · 3 comments · Fixed by #31

Comments

@AdheipSingh
Copy link
Contributor

@itamar-marom
Copy link
Collaborator

In what cases are we skipping a CR?

  1. When it has Spec.Ignored
    What else?

Regarding the Spec.Ignored - I think it should be changed to an annotation. The problem with it in the spec is that it makes me create a function for a predicate which will get an object and will need to convert it to Druid. I don't think that this is something we would like to do.

@AdheipSingh
Copy link
Contributor Author

Yes, you have got it right.

By main concern what i dont want to handle NOT reconciled or ignored objects within the reconcile loop, they should be part of predicates and getting filtered out before entering the workerqueue.
I agree on the annotation suggestion

@itamar-marom
Copy link
Collaborator

Opened a draft PR. I'll work on and test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants