Predicate to filter out ignored objects #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
Description
Instead of filtering CRs in the
Reconcile
function, we want predicates to filter them out.This PR deprecates the
Spec.Ignored
and handles the ignore functionality with the annotationdruid.apache.org/ignored
. When the value of this annotation is "true" the object will be ignored. Any other value will reconcile the object.The API still exists to avoid breaking change.
Also, the logic of the
Spec.Ignored
in theReconcile
function has been removed, and a new function has been added to the predicates.Also, some consts has moved to new file -
types.go
This PR has:
Key changed/added files in this PR
predicates.go
handler.go
types.go