Adds service account name to each druid node optionally #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saithal-confluent
changed the title
|
Please resolve conflicts. Also what version of kubebuilder are using ? i see large diff in crd files. |
Reverted to use controller-gen version v0.11.2 and now the diff is minimal. |
|
@saithal-confluent is Confluent using this flavor of the Druid operator? |
AdheipSingh
added a commit
that referenced
this pull request
Jul 28, 2024
* Ingestion Controller (#53) * ingestion spec acc to v3 * task creation * supprt native batch * fix router url * revert license change * revert go mod change * fix main * fix: made some changes as per review comments * fix: removed unused package from ingestion reconciler * rebase 1 * add example * add review * update dockerfile --------- Co-authored-by: avtarOPS <avtarsingh12015@gmail.com> * Update Docs and Tutorials (#138) * docs and tutorials * Refactor/ordering (#123) * (ordering): refactor code * (ordering): refactor code * (ordering): testing * chore(branch): rebase branch with master * fix(tests): validate nodes order by regex * Bump controller-tools version (#140) * Utilize the DruidIngestion controller in e2e tests (#146) * adds needed volumes to eks deployment spec and improves getting started documentation by noting minio dependency (#149) * Add support for annotations on Deployment/StatefulSet resources in DruidNodeSpec (#145) * Add support for annotations on Deployment/StatefulSet resources * Support setting ReplicationControllerAnnotations at the cluster-level * rename replicationControllerAnnotations to workloadAnnotations * suggestions from code review * Add support for multi tier nodes with different PVC sizes (#106) (#152) Co-authored-by: Farhad Farahi <farhad@adjoe.io> * fix: put Druid crds in the appropriate folder specified by Helm (#162) Signed-off-by: ahmed.g <ahmed.g@adjoe.io> Signed-off-by: TessaIO <ahmedgrati1999@gmail.com> * Adds service account name to each druid node optionally (#164) * Adds service account to each druid node optionally * Use controller-gen v0.11.2 --------- Signed-off-by: ahmed.g <ahmed.g@adjoe.io> Signed-off-by: TessaIO <ahmedgrati1999@gmail.com> Co-authored-by: AdheipSingh <34169002+AdheipSingh@users.noreply.github.com> Co-authored-by: avtarOPS <avtarsingh12015@gmail.com> Co-authored-by: Itamar Marom <46691031+itamar-marom@users.noreply.github.com> Co-authored-by: Jesper Larsson <4522613+MrLarssonJr@users.noreply.github.com> Co-authored-by: Sam Wheating <samwheating@gmail.com> Co-authored-by: Evan Jones <evan.a.jones3@gmail.com> Co-authored-by: Farhad Farahi <farhad.farahi@gmail.com> Co-authored-by: Farhad Farahi <farhad@adjoe.io> Co-authored-by: Sadananda Aithal <111732128+saithal-confluent@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds optional service account name to each druid pod via DruidNode spec
Description
Since Druid components talk to each other and each of them have different identity (different deployments / statefulsets ), we would need different service accounts for each Druid component.
However, this is kept optional because its not required by all and the same default service account inherited from the DruidSpec can be used by all.
This PR has:
Key changed/added files in this PR
MyFooOurBarTheirBaz