Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e enhancements #34

Merged
merged 4 commits into from
Apr 17, 2023
Merged

e2e enhancements #34

merged 4 commits into from
Apr 17, 2023

Conversation

avtarOPS
Copy link
Contributor

@avtarOPS avtarOPS commented Apr 7, 2023

Improves #16.

Description

  • Added a script to monitor running task
  • Removed redundant entires from Makefile
  • Updated minio service name

This PR has:

  • been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
  • been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.
Key changed/added files in this PR
  • Makefile
  • e2e/monitor-task.sh
  • e2e/configs/druid-cr.yaml

AdheipSingh
AdheipSingh reviewed Apr 8, 2023
View reviewed changes
Copy link
Contributor

@AdheipSingh AdheipSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM can you check the syntax errors.

@AdheipSingh AdheipSingh merged commit c716a61 into datainfrahq:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdheipSingh AdheipSingh AdheipSingh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avtarOPS @AdheipSingh