Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1103, #1057 #1184

Merged
merged 22 commits into from
Sep 16, 2024
Merged

Fix #1103, #1057 #1184

merged 22 commits into from
Sep 16, 2024

Conversation

dimitri-yatsenko
Copy link
Member

@dimitri-yatsenko dimitri-yatsenko commented Sep 13, 2024

@dimitri-yatsenko dimitri-yatsenko changed the title Fix #1103 Fix #1103, #1057 Sep 14, 2024
@dimitri-yatsenko dimitri-yatsenko marked this pull request as draft September 14, 2024 02:39
@dimitri-yatsenko dimitri-yatsenko marked this pull request as ready for review September 14, 2024 03:48
@dimitri-yatsenko dimitri-yatsenko marked this pull request as draft September 14, 2024 14:44
@dimitri-yatsenko dimitri-yatsenko marked this pull request as ready for review September 16, 2024 00:04
@ethho
Copy link
Contributor

ethho commented Sep 16, 2024

@dimitri-yatsenko Do you want help writing pytests for topo_sort? Or should we just test manually for now?

@dimitri-yatsenko
Copy link
Member Author

topo_sort is already tested by multiple unit tests since it's used in several places. We can add more tests, of course.

Copy link
Contributor

@ethho ethho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

datajoint/diagram.py Outdated Show resolved Hide resolved
datajoint/diagram.py Outdated Show resolved Hide resolved
datajoint/user_tables.py Show resolved Hide resolved
datajoint/dependencies.py Show resolved Hide resolved
dimitri-yatsenko and others added 2 commits September 16, 2024 14:37
Co-authored-by: Ethan Ho <53266718+ethho@users.noreply.github.com>
Co-authored-by: Ethan Ho <53266718+ethho@users.noreply.github.com>
@ethho ethho self-requested a review September 16, 2024 19:45
@ethho ethho merged commit 285605d into datajoint:master Sep 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants