Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor-changes #120

Merged
merged 1 commit into from
Nov 14, 2024
Merged

minor-changes #120

merged 1 commit into from
Nov 14, 2024

Conversation

gopal-mahajan
Copy link
Collaborator

  • Code of Conduct
    Please ensure compliance by reviewing our Code of Conduct.

  • PR Requirements Checklist 📋

    • The commit message aligns with our contribution guidelines.
    • Tests have been added for all changes (bug fixes, features).
    • Documentation has been updated as necessary.
    • A separate branch is created for the changes (no direct commits to main or master).
    • No credentials or sensitive information is included in this commit.
  • Type of Change 💁📜
    (Bug fix, new feature, documentation update, refactor, chore, test, configuration, etc.)
    Briefly describe the changes made:

  • Issue Addressed 🔧
    Fixes #(issue number, if applicable)

  • PR Checklist 📃

    • Relevant documentation has been updated.
    • Changes made in configuration files (example-config, secrets/all-verticles-configs/config.json) have been added to the example-config.
    • Backend component changes (Elasticsearch, Postgres Flyway files, ImmuDB schema, RabbitMQ) have been communicated to the DX DevOps team by tagging @datakaveri/devops in a PR comment.
    • Comments added to clarify complex or critical code areas.
    • No new warnings are introduced with these changes.
    • Tests have been added or updated to verify functionality.
    • All existing and new unit tests pass locally.
    • PMD and Checkstyle issues have been resolved locally.
    • Reviewers have been assigned to the PR for feedback.

@gopal-mahajan gopal-mahajan merged commit 447fcd5 into datakaveri:main Nov 14, 2024
1 check passed
@jenkins-datakaveri
Copy link

Build finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants