Fix: Concurrent Cancellation Exception #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
tanvi029
approved these changes
Aug 8, 2024
|
ok to test |
gopal-mahajan
requested changes
Aug 13, 2024
src/main/java/iudx/catalogue/server/database/mlayer/MlayerDataset.java
Outdated
Show resolved
Hide resolved
src/test/java/iudx/catalogue/server/mlayer/vocabulary/DataModelTest.java
Outdated
Show resolved
Hide resolved
src/test/java/iudx/catalogue/server/mlayer/vocabulary/DataModelTest.java
Outdated
Show resolved
Hide resolved
|
ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fetching data model information from the voc server using the WebClient, we encountered an OutOfMemoryException due to a memory leak. This occurred because a new WebClient & Vertx instance was being created every time the request was made, leading to excessive memory usage creating lot of threads which were never being down once created.
To resolve the issue, made the following changes:
◦ Instead of creating a new WebClient instance for each request, instantiated a single WebClient instance and reused it across the application.
◦ The WebClient instance was created in the DatabaseVerticle and then passed around where needed.