-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RF publish -> push #412
RF publish -> push #412
Conversation
Intermediate summary: it works, but given rather inconvenient output rendering (#390), its not good to merge atm. |
this is just so that tests don't fail. all actual push snippets need to be adjusted/redone once reporting is fixed (#390)
else I reveal its a local path
I think this is okay to merge for now. The first good thing: Everything still works, nothing breaks 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thx for digging through this!
After datalad/datalad#4206, we need to adjust all book examples that use
publish
to instead showpush
.Ultimately, we want to achieve a setup that is more clever than what we have now:
publish
are code-blocks. This prevents that every time the book is build from scratch, a real publish (which would also require force-pushing, and would lead to problems if anyone but me attempts it) needs to be made.The current commit only quickly-and-dirtily replaces all references to publish with push, setting up the configuration and executable code snippets should happen in the next few days.