Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF publish -> push #412

Merged
merged 10 commits into from
Mar 21, 2020
Merged

RF publish -> push #412

merged 10 commits into from
Mar 21, 2020

Conversation

adswa
Copy link
Contributor

@adswa adswa commented Mar 11, 2020

After datalad/datalad#4206, we need to adjust all book examples that use publish to instead show push.
Ultimately, we want to achieve a setup that is more clever than what we have now:

  • ATM, all examples that show publish are code-blocks. This prevents that every time the book is build from scratch, a real publish (which would also require force-pushing, and would lead to problems if anyone but me attempts it) needs to be made.
  • Where we want to go to is executable code snippets and configuring the alternative Git identity with an insteadOf configuration to push to a local dataset sibling instead of the GitHub or Gin repositories that are specified. This way we can also test what breaks.

The current commit only quickly-and-dirtily replaces all references to publish with push, setting up the configuration and executable code snippets should happen in the next few days.

@adswa
Copy link
Contributor Author

adswa commented Mar 12, 2020

Intermediate summary: it works, but given rather inconvenient output rendering (#390), its not good to merge atm.

@adswa adswa changed the title WIP: RF publish -> push RF publish -> push Mar 16, 2020
@adswa
Copy link
Contributor Author

adswa commented Mar 16, 2020

I think this is okay to merge for now. The first good thing: Everything still works, nothing breaks 🎉
Nevertheless, this is just the start of a refactoring, while I removed all notion of datalad publish, I have only replaced two instances of code blocks with actually executable code. The remaining code blocks with are pushing to special remotes (dropbox, and Github with GitLFS), but I would suggest that I tackle them when I replace/update this section with content about the rclone helper

Copy link
Collaborator

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx for digging through this!

@adswa adswa merged commit c45bf9b into master Mar 21, 2020
@adswa adswa deleted the rf-publish branch March 21, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants