Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tmp globus #479

Merged
merged 7 commits into from
May 9, 2020
Merged

Tmp globus #479

merged 7 commits into from
May 9, 2020

Conversation

adswa
Copy link
Contributor

@adswa adswa commented May 8, 2020

No description provided.

@adswa adswa mentioned this pull request May 8, 2020
Closed
@gi114
Copy link
Contributor

gi114 commented May 8, 2020

Hi @adswa,

The other PR is closed so we can go ahead with this one

@adswa
Globus: Proof-reading/tweaks
e57643e 
This commit is the result of proofreading and streamlining the new
Globus data eco system PR. It includes:

- a few typo fixes
- some general tweaks to the language, such as minor reordering of paragraphs,
  sentence structure/idiom fixes (behind the hood -> under the hood)
- A polished/reordered introduction (highlighting the new special remote and
  data dissemination)
- Usage of terms that exist in the glossary, where applicable
- Referencing some other useful handbook chapters for further information, where
  applicable
- Highlighting the tutorial in the special-remotes README by introducing a
  Resources paragraph
- Including one footnote and a findoutmore
@adswa
Copy link
Contributor Author

adswa commented May 9, 2020

Thank you, @gi114!
I like your edits, I think they improve the usecase a lot! I have pushed e57643e that aims to streamline the new usecase to the existing content. I've taken the liberty to reference terms in the glossary or other handbook chapters, where it made sense, and I have rearranged on edited some paragraphs, put one paragraph of yours into a findoutmore directive, and added a footnote with some chapter references.

If you are fine with those changes, let's merge!

hey @all-contributors please add @gi114 for content and example

@allcontributors allcontributors bot mentioned this pull request May 9, 2020
Merged
@allcontributors
Copy link
Contributor

@adswa

I've put up a pull request to add @gi114! 🎉

@gi114
Copy link
Contributor

gi114 commented May 9, 2020

Hi @adswa ,

Thanks a lot! I am good with merging the PR

@adswa adswa merged commit 92ff88a into master May 9, 2020
@adswa adswa deleted the TMP-globus branch January 29, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gi114 gi114 gi114 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adswa @gi114