Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally depend on server ydoc and docprovider #21

Merged

Conversation

krassowski
Copy link
Collaborator

  • Replace optional dependency on entire jupyter-collaboration package with only the packages which are needed
  • Add the optional extras [lab] to the README
  • Align require JupyterLab version in the README

Copy link

Binder 👈 Launch a Binder on branch krassowski/jupyter-server-nbmodel/depend-on-server-ydoc-and-docprovider

@krassowski krassowski mentioned this pull request Jul 19, 2024
@krassowski
Copy link
Collaborator Author

@fcollonval what do you think?

@fcollonval fcollonval added the documentation Improvements or additions to documentation label Jul 29, 2024
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krassowski

@fcollonval fcollonval merged commit 2facfb3 into datalayer:main Jul 29, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants