Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Serilog.Sinks.PeriodicBatching 2.1 #38

Closed
nblumhardt opened this issue Oct 30, 2016 · 1 comment
Closed

Update to Serilog.Sinks.PeriodicBatching 2.1 #38

nblumhardt opened this issue Oct 30, 2016 · 1 comment

Comments

@nblumhardt
Copy link
Member

The updated package removes an erroneous dependency on System.Threading.Thread that prevents installation into UWP apps.

As part of this work we should support the new bounded queue feature supported by the new version of PeriodicBatchingSink.
nblumhardt added a commit to nblumhardt/serilog-sinks-seq that referenced this issue Oct 31, 2016
@nblumhardt
Fixes datalust#38 - update Serilog.Sinks.PeriodicBatching, support qu…
c8b1f82 
…eueSizeLimit.
@nblumhardt nblumhardt mentioned this issue Oct 31, 2016
Merged
@nblumhardt
Copy link
Member Author

Done, in the above PR, though it seems the dependency on System.Threading was fine. Needed to add it as a direct dependency of the Seq sink for .NET Standard 1.3+, where Thread.Sleep() is used. Taking the portable timer implementation from Serilog.Sinks.PeriodicBatching would eliminate this.

@nblumhardt nblumhardt mentioned this issue Nov 4, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nblumhardt