Extract HTTP ingestion API interactions and refactor #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets us into a better position for testing significant changes and future additions :-)
SeqIngestionApinow provides a (very thin) abstraction over the POSTs to the ingestion endpoint. This gets a lot of duplication out of the sinks, and makes unit testing the sinks (and eventuallyHttpLogShipper) easier.I haven't tried to completely abstract away the HTTP-dependent aspect of this, since there's not currently any great benefit from doing so, and we'll end up having to clutter the code up by defining our own equivalents of HTTP status codes etc.
There are only two behavioral changes here (that I know of) which deserve a call-out.
Response bodies will no longer be written to
SelfLogby the durable sink when logging fails. Done for simplification; the ingestion log should cover this case, and we don't do it in batched or audit mode, so seems reasonable to stop doing it in durable mode.If we want to add this back for additional diagnostics, providing some hooks at the top level for handling failed ingestion response bodies would be better.
Audit sink writes will read the full response, though they'll discard it. Probably irrelevant, since the responses are tiny and would more than likely have been buffered in the network stack before the response reaches us.