Update to Serilog 4 (prerelease) #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KodrAus
reviewed
May 6, 2024
| } | ||
| } | ||
|
|
||
| public async Task EmitBatchAsync(IEnumerable<LogEvent> events) | ||
| public async Task EmitBatchAsync(IReadOnlyCollection<LogEvent> events) |
There was a problem hiding this comment.
Ah I see that's a pretty significant API difference between the old batching sink and the new one? IReadOnlyCollection does seem like a better interface here.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops the Serilog.Sinks.PeriodicBatching dependency. There isn't any breaking or visible surface area change, but pulling Serilog up a major version, and no longer pulling in the latest s.s.PeriodicBatching will have enough impact on consumers to warrant a major version bump.