Calypso undefined protection #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactor the SingleNews component just a little bit
foodelevator
reviewed
Apr 2, 2024
| </header> | ||
| <Translate> | ||
| <English>{`${item ? item.titleEnglish : "????"} - Konglig Datasektionen`}</English> | ||
| <Swedish>{`${item ? item.titleSwedish : "????"} - Konglig Datasektionen`}</Swedish> |
There was a problem hiding this comment.
(it is an edgecase, and only appears in the browser titlebar, so I thought it was kinda funny to keep it that way)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently Calypso doesn't return json for some malformed queries.
(eg. https://calypso.datasektionen.se/api/item/[)
This adds undefined protection for one of the places that uses the Calypso component.
This is the only instance of the
Calypsocomponent that fetches a direct item, all other ones fetches a list of items with some kind of filter applied, and should not be affected by this particular error.I started refactoring the component a bit, but decided to not do too much. Getting an itch from it, so might do a larger refactor at some point.